Re: smtpmail.el: set-buffer-file-coding-system takes too many args

[Reiner Steib]

Eli,

could comment on this (your 2006-11-24 change to smtpmail.el), please?

Bye, Reiner.


Original message follows...

On Sun, Jan 07 2007, Reiner Steib wrote:

> On Sun, Jan 07 2007, Simon Josefsson wrote:
>
>> Reiner Steib <address@hidden> writes:
>>> BTW: Is NOMODIFY really useful here?  In both cases,
>>> `set-buffer-file-coding-system' is followed by
>>> `insert-buffer-substring' which will mark the buffer modified anyhow.
>>> What am I missing?
>>
>> Hm, I agree that it looks funny.  Maybe you could ask whomever applied
>> this, if it is really needed?  I agree that it doesn't seem very
>> useful, and the modified-flag seems rather pointless for temporary
>> buffers anyway.
>
> Eli, we wonder if the NOMODIFY argument to
> `set-buffer-file-coding-system' in your 2006-11-24 change of
> `smtpmail.el' (see below) is useful.  NOMODIFY breaks compatibility
> with Emacs 21.  Although it's not a goal for `smtpmail.el' in Emacs
> CVS to be compatible with Emacs 21, it would be "nice-to-have" because
> `smtpmail.el' provides very useful features for Gnus user on Emacs 21
> (SMTP-AUTH, STARTTLS, ...).  This was the reason why we include a copy
> of `smtpmail.el' from Emacs in Gnus' contrib directory.
>
> (See
> http://thread.gmane.org/gmane.emacs.gnus.general/64222/focus=64233 for
> the rest of this thread.)
>
> ,----
> | 2006-11-24  Eli Zaretskii  <address@hidden>
> | 
> |     * mail/smtpmail.el (smtpmail-send-it):
> |     Copy buffer-file-coding-system from the mail buffer.  Possibly add a
> |     MIME header for the message encoding.
> |     Bind coding-system-for-write around the call to mail-do-fcc.
> |     Use smtpmail-code-conv-from to encode queued mail messages.
> `----
>
> --- smtpmail.el       18 Oct 2006 11:11:32 -0000      1.88
> +++ smtpmail.el       24 Nov 2006 14:32:19 -0000      1.89
> @@ -244,6 +244,11 @@
>       (save-excursion
>         (set-buffer tembuf)
>         (erase-buffer)
> +       ;; Use the same buffer-file-coding-system as in the mail
> +       ;; buffer, otherwise any write-region invocations (e.g., in
> +       ;; mail-do-fcc below) will annoy with asking for a suitable
> +       ;; encoding.
> +       (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
>         (insert-buffer-substring mailbuf)
>         (goto-char (point-max))
>         ;; require one newline at the end.
>
> [...]
> @@ -370,6 +394,7 @@
>               (make-directory smtpmail-queue-dir t))
>             (with-current-buffer buffer-data
>               (erase-buffer)
> +             (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
>               (insert-buffer-substring tembuf)
>               (write-file file-data)
>               (set-buffer buffer-elisp)