emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The doc string for a globalized minor mode should linke to the mode


From: Lennart Borgman (gmail)
Subject: Re: The doc string for a globalized minor mode should linke to the mode
Date: Wed, 18 Apr 2007 17:23:34 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.10) Gecko/20070221 Thunderbird/1.5.0.10 Mnenhy/0.7.5.666

Richard Stallman wrote:
    Subject: The doc string for a globalized minor mode should linke to the mode

I am not entirely sure what that means.  Could you be more specific?

Can you write a fix?


I would prefer something like this:

Index: easy-mmode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v
retrieving revision 1.82
diff -c -r1.82 easy-mmode.el
*** easy-mmode.el       3 Feb 2007 17:26:28 -0000       1.82
--- easy-mmode.el       18 Apr 2007 15:22:58 -0000
***************
*** 295,301 ****
  call another major mode in their body."

    (let* ((global-mode-name (symbol-name global-mode))
-        (pretty-name (easy-mmode-pretty-mode-name mode))
         (pretty-global-name (easy-mmode-pretty-mode-name global-mode))
         (group nil)
         (extra-keywords nil)
--- 295,300 ----
***************
*** 327,337 ****
         (make-variable-buffer-local ',MODE-major-mode)
         ;; The actual global minor-mode
         (define-minor-mode ,global-mode
!        ,(format "Toggle %s in every buffer.
  With prefix ARG, turn %s on if and only if ARG is positive.
! %s is actually not turned on in every buffer but only in those
  in which `%s' turns it on."
!                 pretty-name pretty-global-name pretty-name turn-on)
         :global t ,@group ,@(nreverse extra-keywords)

         ;; Setup hook to handle future mode changes and new buffers.
--- 326,337 ----
         (make-variable-buffer-local ',MODE-major-mode)
         ;; The actual global minor-mode
         (define-minor-mode ,global-mode
!        ,(format "Toggle `%s' in every buffer.
  With prefix ARG, turn %s on if and only if ARG is positive.
!
! `%s' is actually not turned on in every buffer but only in those
  in which `%s' turns it on."
!                 mode pretty-global-name mode turn-on)
         :global t ,@group ,@(nreverse extra-keywords)

         ;; Setup hook to handle future mode changes and new buffers.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]