Re: Multi-tty design (Re: Reordering etc/NEWS)

[Dan Nicolaescu]

David Kastrup <address@hidden> writes:

  > Dan Nicolaescu <address@hidden> writes:
  > 
  > > David Kastrup <address@hidden> writes:
  > >
  > >   > Dan Nicolaescu <address@hidden> writes:
  > >   > 
  > >   > > David Kastrup <address@hidden> writes:
  > >   > >
  > >   > >   > Andreas Schwab <address@hidden> writes:
  > >   > >   > 
  > >   > >   > > David Kastrup <address@hidden> writes:
  > >   > >   > >
  > >   > >   > >> Thanks for your input.  But all other applications
  > >   > >   > >> (including Emacs 22.x) run in this situation using
  > >   > >   > >> either tty or DISPLAY.
  > >   > >   > >
  > >   > >   > > Worksforme.
  > >   > >   > 
  > >   > >   > Current checkout of multi-tty from Savannah CVS?
  > >   > >
  > >   > > Worksforme too, current checkout of multi-tty from Savannah
  > >   > > CVS, then ./configure --prefix=..... ; make bootstrap strace
  > >   > > of src/emacs -Q -nw shows that it's using terminfo not
  > >   > > termcap. What system are you on?
  > >   > 
  > >   > Ubuntu Feisty.
  > >
  > > I tried this on a Ubuntu Feisty machine, but that machine does not
  > > have the X11 headers installed, so I could only compile a terminal
  > > based emacs.
  > >
  > > But this emacs would say "invalid argument framep 1" at startup. I
  > > set debug-on-error to t and run C-x 5 2. The backtrace showed that
  > > the error is in `getenv' and it is cause by an env.el change that
  > > YOU installed on the multi-tty branch without a ChangeLog.
  > 
  > If you tell me where to place the ChangeLog...  There is a CVS log
  > entry.
  > 
  > > PLEASE REVERT THE CHANGE! It is never a good idea to install changes
  > > without testing them, and you obviously didn't.
  > 
  > I did in a running session.  Anyway, if you bother to look at the
  > change, it does nothing except make the getenv actually do what its
  > DOC string claims to do.
  > 
  > So reverting the change is not the right solution.  Personally, I
  > think the arguments of getenv and setenv are completely messed up.

It is at this point. You changed the code from working into
non-working, and it's already stopping other people from testing
it. There was already a but report about this.

You can improve it later if you want it, but now it does not work, and
that reflects badly on the all the effort that was put into multi-tty.