[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFA] Console based mouse face highlighting.
From: |
Nick Roberts |
Subject: |
Re: [RFA] Console based mouse face highlighting. |
Date: |
Thu, 17 May 2007 15:54:34 +1200 |
> > I can't easily add an extra argument to write_glyphs as it's called in many
> > places.
>
> But it sounds like all of them but one should be called with that
> argument zero, so it shouldn't be too hard to convert them. Am I
> missing something?
Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so
places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and
perhaps w32con_write_glyphs). If you're comfortable with those changes and
still think it's the right approach, I'll do that.
> > Do you mean something like below? (I've tested it and it works too.)
> > It's certainly more lightweght, but I think global variables tend to spoil
> > the flow.
>
> Yes, that's what I had in mind. But isn't it equivalent to calling
> write_glyphs with the additional flag argument non-zero in just this
> one place? That would eliminate the need for a global variable.
Yes, I think they're equivalent.
--
Nick http://www.inet.net.nz/~nickrob
- Re: [PATCH] Console based mouse face highlighting., (continued)
- Re: [PATCH/Now RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/15
- Re: [PATCH/Now RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/15
- Re: [PATCH/Now RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/16
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/16
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/16
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/16
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/16
- Re: [RFA] Console based mouse face highlighting.,
Nick Roberts <=
- Re: [RFA] Console based mouse face highlighting., Stefan Monnier, 2007/05/17
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/17
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/17
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/17
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/17
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/18
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/18
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/19
- Re: [RFA] Console based mouse face highlighting., Nick Roberts, 2007/05/19
- Re: [RFA] Console based mouse face highlighting., Eli Zaretskii, 2007/05/19