Re: gas-mode.el - Comments welcome

[David Kastrup]

"Heike C. Zimmerer" <address@hidden> writes:

>> - fix naming to use the `gas-' (or `asm-') prefix for vars such as
>>   `line-cache'.  Provide defvars with docstring explaning what
>>   they contain.
>
> The caches are always buffer-local.  According to what I learned
> from the documentation, the prefix is only required for globals.

Buffer-local variables have global bindings (they don't go away after
a function finishes).  You are confusing them with let-bound
variables.

> I sometimes even deliberately removed the prefix from symbols to
> emphasize on its local binding (as here).  Anything wrong with it?

Yes.  Conflict with similarly named variables elsewhere.

-- 
David Kastrup