emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Several small timeclock fixes


From: Davis Herring
Subject: Re: Several small timeclock fixes
Date: Fri, 8 Jun 2007 12:53:40 -0700 (PDT)
User-agent: SquirrelMail/1.4.8-6.el3.2lanl

I wrote this when supplying (or rather forgetting to supply; I sent it
later) a complex patch for timeclock.el:

> A single ChangeLog entry for all these changes:
>
> 2007-04-23  Davis Herring  <address@hidden>
>
>       * calendar/timeclock.el: Update version number.
>       (timeclock-modeline-display): Mention timeclock-use-display-time
>       in explanatory message.
>       (timeclock-in): Fix non-interactive workday specifications.
>       (timeclock-log): Don't kill the log buffer if it already existed.
>       Suppress warnings when finding the log.  Don't check for a nil
>       project twice.  Run hooks after killing the buffer (if
>       applicable).
>       (timeclock-geometric-mean): Rename to `timeclock-mean' (it never
>       was geometric).  All uses changed.
>       (timeclock-generate-report): Support prefix argument.

That ChangeLog entry is incomplete, for the simple reason that I included
(in the patch that was eventually installed) a convenience function of
mine (`timeclock-make-hours-explicit') that I don't recall really meaning
to include.

There's nothing wrong with it, and it's in Emacs 22.1, so it should
probably stay.  But it should at the very least get a ChangeLog mention
(obviously just "New function."), and perhaps a mention in (emacs)Time
Intervals or so.

What more do I need to contribute for this, and (while on the subject)
could it get a look-over to make sure that it is only "extra" and not
broken?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]