Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Eric M. Ludlam]

Hi,

  The speedbar frame stays "live" but hidden so that the next time
speedbar comes up, it will be faster.  You can use 'q' to hide
speedbar, and 'Q' to really kill speedbar.

  I tried it out, and it seems the speed difference is currently very
small now, so the optimization is not as important as it once was.

  I suspect your patch might leave a bunch of invisible frames about,
but it's been a while since I've been in that code so I'm not sure.

Eric

>>> "Juanma Barranquero" <address@hidden> seems to think that:
>On 6/25/07, Angelo Graziosi <address@hidden> wrote:
>
>> It look as if the speedbar were still 'live'
>
>It is live, if somewhat hidden :)
>
>Try the following patch.
>
>             Juanma
>
>
>P.S.: Eric, is this patch OK?
>
>
>
>Index: lisp/speedbar.el
>===================================================================
>RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v
>retrieving revision 1.87
>diff -u -2 -r1.87 speedbar.el
>--- lisp/speedbar.el   19 Feb 2007 13:37:23 -0000      1.87
>+++ lisp/speedbar.el   25 Jun 2007 10:24:07 -0000
>@@ -1012,6 +1012,8 @@
>     )
>   ;; Frame modifications
>-  (set (make-local-variable 'dframe-delete-frame-function)
>-       'speedbar-handle-delete-frame)
>+  (if speedbar-frame
>+      (set (make-local-variable 'dframe-delete-frame-function)
>+         'speedbar-handle-delete-frame)
>+    (kill-local-variable 'dframe-delete-frame-function))
>   ;; hscroll
>   (set (make-local-variable 'automatic-hscrolling) nil) ; Emacs 21
>

-- 
          Eric Ludlam:                 address@hidden, address@hidden
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org