Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Stefan Monnier <address@hidden> writes:

  > > I think `C-x C-q' is a good key binding, but it has one problem.
  > > For users who have a habit typing `C-x C-q' repeatedly to switch
  > > between editable and read-only states, typing `C-x C-q' in wdired mode
  > > will put the dired buffer into the confusing state: the mode line still
  > > says "Editable Dired", but the buffer is read-only now.  Users who don't
  > > notice %%-characters in the mode line might have a hard time finding
  > > out what happened.
  > 
  > Yes, there needs to be a bit more work to make the C-x C-q binding
  > work correctly.  That's why I didn't add the binding when I originally
  > installed the wdired.el code.
  > 
  > Now that the binding is added, let's fix the problem.

Just so there's not confusion: the problem with the effects of C-x C-q
in wdired more existed before the new key bindings was added.

Now, what should C-x C-q do in wdired mode? 
How about this: 

if not buffer-modified-p
   switch back to dired-mode
else
   print a warning that the user needs to either save her changes or
   cancel them