Re: address@hidden: Re: problem with transparent PNG image display]

[YAMAMOTO Mitsuharu]

>>>>> On Wed, 01 Aug 2007 16:55:30 +0100, Jason Rumney <address@hidden> said:

> Miles Bader wrote:
>> I thought it already did this (in image.c:search_image_cache):
>> 
>> 2007-06-13  YAMAMOTO Mitsuharu  <address@hidden>
>> 
>> * dispextern.h (struct image) [HAVE_WINDOW_SYSTEM]: New members
>> frame_foreground and frame_background.
>> 
>> * image.c (lookup_image): Save frame foreground and background colors.
>> (search_image_cache): Check if saved and current frame colors match.
>> 

> I think its the background on which the image is rendered that is
> important, not the frame background. The toolbar has its own background
> color, independent of the frame's. And that only covers caching, images
> still need to be drawn with the appropriate background from the face
> rather than the background color saved in the image file itself.

FWIW, that change was just for fixing excessive image cache miss (and
performance degradation caused by needless image regeneration) in the
trunk, without affecting its original intention.

                                     YAMAMOTO Mitsuharu
                                address@hidden