emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

typo? in tty_supports_face_attributes_p


From: Masatake YAMATO
Subject: typo? in tty_supports_face_attributes_p
Date: Mon, 06 Aug 2007 04:28:14 +0900 (JST)

Can I ask you to review following patch?

While reading xfaces.c, I found unsymmetrical code.
I guess these are typos. However I could not find the way
to reproduce a bug which these typos cause quickly.
If you know well about these area, could you take your
time to review this patch? Forgive me my lazyness.

Thanks in advance.
Masatake

--- xfaces.c    26  7月 2007 14:28:01 +0900      1.362
+++ xfaces.c    06  8月 2007 04:19:02 +0900      
@@ -6066,7 +6066,7 @@
   val = attrs[LFACE_INVERSE_INDEX];
   if (!UNSPECIFIEDP (val))
     {
-      if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX]))
+      if (face_attr_equal_p (val, def_attrs[LFACE_INVERSE_INDEX]))
        return 0;               /* same as default */
       else
        test_caps |= TTY_CAP_INVERSE;
@@ -6109,7 +6109,7 @@
   bg = attrs[LFACE_BACKGROUND_INDEX];
   if (STRINGP (bg))
     {
-      Lisp_Object def_bg = def_attrs[LFACE_FOREGROUND_INDEX];
+      Lisp_Object def_bg = def_attrs[LFACE_BACKGROUND_INDEX];
 
       if (face_attr_equal_p (bg, def_bg))
        return 0;               /* same as default */




reply via email to

[Prev in Thread] Current Thread [Next in Thread]