Re: corrupted ,v files break cvs-to-git mirror

[Jim Meyering]

Miles Bader <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> Does anyone here have any idea how that happened?
>> FYI, here's the second "1.1" log entry, from "cvs log" output:
>> [What does "Moved" mean? ]
>>
>>     ----------------------------
>>     revision 1.1
>>     date: 2005/08/23 20:05:32;  author: jhd;  state: Exp;
>>     Moved from international.  Old log:
>>     ;;; swedish.el --- miscellaneous functions for dealing with Swedish.
>>     ----------------------------
>>     revision 1.12
>>     date: 2005/07/04 17:22:27;  author: lute;  state: Exp;  lines: +2 -2
>>     Update FSF's address.
>>     ----------------------------
>>
>> I hope it's easily fixed.
>
> It looks as if the stuff past "Moved old log:" are _not_ actual CVS
> revisions, but all part of the _log message_ for revision 1.1 -- i.e.,
> the person who did the "move" just copied the entire CVS log of from the
> old location verbatim, and stuffed into his log entry.

Yep.  I should have looked directly at the ,v file.

> So if that's the case probably CVS isn't confused, because it should do
> proper escaping of log messages, but any tools which try to parse the
> output of "cvs log" will be very confused (as I guess your tool was).

Yes.  For cvsps to do its job properly, it would need an rlog-style
log-listing tool, with an option to produce unambiguous (i.e., NUL-separated)
blocks of per-revision data.

> I guess you can fix it just by  giving revision 1.1 a differnt log
> message without all the annoying stuff (using "cvs admin -m...").

I've already modified the ,v files in a mirror hierarchy and
confirmed that it avoids the infloop.  If I hear no objection
in the next few hours, I'll update the official ,v files on savannah.

lisp/obsolete/iso-swed.el has the same problem.