Re: Failure in building Emacs 23.0.50 on Cygwin

[Eli Zaretskii]

> From: Dan Nicolaescu <address@hidden>
> Date: Fri, 31 Aug 2007 17:35:58 -0700
> Cc: address@hidden
> 
>   > > term.o: In function `dissociate_if_controlling_tty':
>   > > /tmp/emacs/src/term.c:3146: undefined reference to `_croak'
>   > 
>   > 
>   > I believe, the problem is that "croak" is not being properly defined in 
> the
>   > "sysdep.c" file.  It is only manifested when trying to compile term.c 
> which refers to croak.
>   > 
>   > How should one define "croak" in sysdep.c for "i686-pc-cygwin" to test 
> this?
>   >    Ref: config.log:Target: i686-pc-cygwin
> 
> IMO the question should be asked the other way: how do you avoid
> references to "croak". 

I think this is not a good idea.  If multi-tty relies on `croak' to
flag features that various ports need to implement, then `croak'
should be available for all platforms, at least until such time as all
the main supported platforms implement all such features.
(Personally, I would leave `croak' in Emacs even after that, since
it's such a small function, but that's me.)

> Adjust preprocessor code in dissociate_if_controlling_tty so that
> croak is not used.

That's sweeping the problem under the carpet; not a good idea, IMO.