Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

What do you think about this patch ?

------------------------------------------------------------------------
--- term.c.orig 2007-08-29 23:46:50.000000000 +0200
+++ term.c      2007-09-03 00:38:43.538785600 +0200
@@ -3127,8 +3127,12 @@
   EMACS_GET_TTY_PGRP (fd, &pgid); /* If tcgetpgrp succeeds, fd is the
ctty. */
   if (pgid != -1)
     {
-#if defined (USG) && !defined (BSD_PGRPS)
+#if (defined (USG) && !defined (BSD_PGRPS)) || (defined (CYGWIN))
+#ifdef CYGWIN
+      setsid ();
+#else
       setpgrp ();
+#endif  /* ! CYGWIN */
       no_controlling_tty = 1;
 #else
 #ifdef TIOCNOTTY                /* Try BSD ioctls. */
------------------------------------------------------------------------

With it I have build Emacs and it seems to work (usually I use it from X
shell). But, perhaps, you can suggest some more specific test.


Cheers,

  Angelo.


On Mon, 3 Sep 2007, d.henman wrote:

>
> Looks like a good find Angelo.
> I have just sent mail to the cygwin developers list to confirm, if this is
> still the preferred method of if anything newer exists.
>
> Regards,
>   Darel Henman
>
> Angelo Graziosi <address@hidden> wrote:
> >
> > Searching Cygwin lists archives, I have found this 'laconic' suggestion,
> >
> >    http://sourceware.org/ml/cygwin/2001-08/msg00753.html
> >
> >
> > Could it help in solving our problem?
> >
> >
> > Cheers,
> >
> >    Angelo.
> >
>
>