emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)


From: d.henman
Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)
Date: Mon, 03 Sep 2007 09:23:34 +0900

Angelo,

content wise it looks good to me, but I think that changing it to the following 
format, same content as your patch (see modifed patch below ), but this format 
makes it easier to understand and would give it more robustness for future 
mainenance and any possible changes and extensions for CYGWIN specific issues.

Also I would like to wait and get a response from the cygwin developers, before 
any commit is made.

Regards,
  Darel Henman

----------------------------------------------------------------
--- term.c      2007-08-30 06:46:50.000000000 +0900
+++ /tmp/term.c.fixed   2007-09-03 09:15:22.915209300 +0900
@@ -3131,6 +3131,10 @@
       setpgrp ();
       no_controlling_tty = 1;
 #else
+#ifdef CYGWIN
+      setsid ();
+      no_controlling_tty = 1;
+#else
 #ifdef TIOCNOTTY                /* Try BSD ioctls. */
       sigblock (sigmask (SIGTTOU));
       fd = emacs_open ("/dev/tty", O_RDWR, 0);
@@ -3145,6 +3149,7 @@
       /* Unknown system. */
       croak ();
 #endif  /* ! TIOCNOTTY */
+#endif  /* ! CYGWIN */
 #endif  /* ! USG */
     }
 #endif
----------------------------------------------------------------




reply via email to

[Prev in Thread] Current Thread [Next in Thread]