emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: display-completion-list should not strip text properties


From: Drew Adams
Subject: RE: display-completion-list should not strip text properties
Date: Wed, 5 Sep 2007 07:21:12 -0700

>     I'd extend this \# syntax to support other text properties by having
>     \#(prop value ...) text# mean (propertize "text" 'prop 'value '...),
>     and of course have \#value text# imply \#(highlight value) text#.
>
> Why do we need to put properties other that the `face' property
> in doc strings?  There are already ways to make links.

To include graphics in Help, for one thing. Johan makes that point in his
mail quoted below.

>     1. Let's accept Johan's fix for `describe-variable'.
>
> Please send this fix again -- I don't remember it.

Le voici :

> From: Johan "Bockgård" Sent: Wednesday, January 24, 2007 3:43 PM
> Subject: Re: display-completion-list should not strip text properties
>
> Richard Stallman <address@hidden> writes:
>
> > I agree that this is a good change, and since it is simple and safe,
> > we can do it now.
>
> Here's a related, simple, change that I've been sitting on for a long
> time. By putting text properties on doc strings you can insert images
> and other fancy stuff in the *Help* buffer. This change makes
> describe-variable preserve text properties (describe-function already
> does so):
>
> 2007-01-24  Johan Bockgård  <address@hidden>
>
>             * help-fns.el (describe-variable): Keep doc's text properties.
>
> Index: lisp/help-fns.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/help-fns.el,v
> retrieving revision 1.96
> diff -u -r1.96 help-fns.el
> --- lisp/help-fns.el  23 Jan 2007 07:16:11 -0000      1.96
> +++ lisp/help-fns.el  24 Jan 2007 23:15:35 -0000
> @@ -596,7 +596,8 @@
>                          "which is byte-compiled expression.\n"
>                        (format "`%s'.\n" safe-var))))
>             (princ "\nDocumentation:\n")
> -              (princ (or doc "Not documented as a variable.")))
> +              (with-current-buffer standard-output
> +             (insert (or doc "Not documented as a variable."))))
>           ;; Make a link to customize if this variable can be customized.
>           (if (custom-variable-p variable)
>               (let ((customize-label "customize"))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]