Re: Your last change to browse-url is bogus.

[Michaël Cadilhac]

YAMAMOTO Mitsuharu <address@hidden> writes:

> Your point of view is low-level (string operation), and mine is
> high-level (URL operation).  The problems is that the current
> implementation of browse-url-encode-url is neither of them: it looks
> like a result of superficial code factoring.

I do agree.

> I propose the combination of above two, which is similar to what Davis
> suggested:
>
>   1. Add a low-level string replacing function (say,
>      browse-url-encode-chars-in-string as you mentioned) that takes an
>      argument representing the characters to be escaped.
>
>   2. In browse-url-file-url, directly call the above low-level
>      function instead of calling browse-url-encode-url.
>
>   3. Change browse-url-encode-url so it calls the the low-level
>      function introduced in 1, and just do one task (URL -> URL).

Yeah, I did that on the weekend.  If nobody complains, it seems that we
agree that this is TRT, so I'll install the change later on.

Thank you all for this debate.

-- 
 |   Michaël `Micha' Cadilhac       |   Je veut dire que la loi francaise    |
 |   http://michael.cadilhac.name   |           est overwritable par le      |
 |   JID/MSN:                       |    reglement interieur il me semble.   |
 `----  address@hidden  |          -- ElBarto               -  --'

pgpTYjAR96tGA.pgp
Description: PGP signature