Re: TAB when the region is active

[Stefan Monnier]

>> > Here's my first try at doing this.
>> The change should not be in indent-according-to-mode, but in
>> indent-for-tab-command.

> If I do it like this:

> *** indent.el 26 Jul 2007 10:17:33 -0700      1.68
> --- indent.el 19 Sep 2007 18:29:56 -0700      
> ***************
> *** 98,104 ****
>      ((memq indent-line-function '(indent-relative indent-relative-maybe))
>       (funcall indent-line-function))
>      (t ;; The normal case.
> !     (indent-according-to-mode))))
  
>   (defun insert-tab (&optional arg)
>     (let ((count (prefix-numeric-value arg)))
> --- 101,110 ----
>      ((memq indent-line-function '(indent-relative indent-relative-maybe))
>       (funcall indent-line-function))
>      (t ;; The normal case.
> !     (if (and transient-mark-mode mark-active
> !     (not (eq (region-beginning) (region-end))))
> !     (indent-region (region-beginning) (region-end))
> !       (indent-according-to-mode)))))

Please don't use an `if' in the tail of a `cond': just place the condition
directly in the `cond'.
  
>   (defun insert-tab (&optional arg)
>     (let ((count (prefix-numeric-value arg)))

> then indenting the region by pressing TAB does not work in c-mode
> anymore (it did work in my first try).

Sure.  Some modes use the default behavior of TAB (e.g. it obeys
tab-always-indent), others override it.  Those who override it have their
reason to do it, so we may want to tell them about it, but we shouldn't
impose it.

Putting the code in indent-according-to-mode will introduce bugs in code
that calls it specifically to indent a single line.  It is just the
wrong place.

> Should c-mode also not bind TAB?

That's up to the maintainer of c-mode.


        Stefan