Gtk+ stock tool bar icons

[Reiner Steib]

Hi,

Emacs trunk and EMACS_22_BASE (=> Emacs 22.2) now have:

,----[ NEWS ]
| * Changes in Emacs 22.2
| 
| ** The Gtk+ build now uses stock tool bar icons, so that a theme change
| is visible in Emacs tool bar.
`----

Up to now (AFAIK [1]), only the default Emacs tool bar has been
updated completely [2].  So for other modes, the user will get a
mixture of themed and un-themed icons (e.g. Info, Gnus, Message,
probably also MH-E).  Here are some screen shots from CVS trunk
(including my attempt to add mappings for Gnus icons to
`x-gtk-stock-map' [3]).

I'm not sure if its a good idea to enable the GTK stock mapping in
EMACS_22_BASE by default if we plan to release Emacs 22.2 soon.
What is better:

(a) A consistent icons style within Emacs (like in Emacs 22.1)

or

(b) Consistent icons between the (Gnome) desktop environment and parts
    of (GTK-) Emacs and inconsistent icons within several tool bars in
    Emacs.  See the screen shots on [4].

Some related questions:

- Is (setq x-gtk-stock-map nil) the recommended way to disable themed
  icons?  Shouldn't we provide this as a custom option (also in Emacs
  trunk) and mention it in NEWS?  (BTW, the custom version should read
  22.2 if we keep it in EMACS_22_BASE, shouldn't it?)

- Is my patch [3] correct?

- For Gnus, we have at least two icons where no corresponding
  Gnome/GTK icon was (is) available.  How can we should we deal with
  this?  (Probably the same is relevant for prev-node, next-node and
  up-node?)

  mail/preview.xpm (combining stock_mail and stock_zoom)
  mail/save.xpm    (combining stock_mail, stock_save and stock_convert)

- How is possible to try different icon styles for non-Gnome user?

Bye, Reiner.

[1] Maybe I missed some discussion on emacs-devel as I was on vacation.

[2] Info mode is only partially updated.  Previous, Next and Up node
    have un-themed icons.

[3]
--8<---------------cut here---------------start------------->8---
--- x-win.el    23 Sep 2007 18:33:46 +0200      1.210
+++ x-win.el    29 Sep 2007 15:18:32 +0200      
@@ -2587,7 +2587,43 @@
     ("etc/images/jump-to" . "gtk-jump-to")
     ("etc/images/index" . "gtk-index")
     ("etc/images/search" . "gtk-find")
-    ("etc/images/exit" . "gtk-quit"))
+    ("etc/images/exit" . "gtk-quit")
+    ;; Used in MH-E and/or Gnus:
+    ("etc/images/attach.xpm" . "gtk-attach")
+    ("etc/images/connect.xpm" . "gtk-connect")
+    ("etc/images/contact.xpm" . "gtk-contact")
+    ("etc/images/delete.xpm" . "gtk-delete")
+    ("etc/images/describe.xpm" . "gtk-properties")
+    ("etc/images/disconnect.xpm" . "gtk-disconnect")
+    ;; ("etc/images/exit.xpm" . "gtk-exit")
+    ("etc/images/lock-broken.xpm" . "gtk-lock_broken")
+    ("etc/images/lock-ok.xpm" . "gtk-lock_ok")
+    ("etc/images/lock.xpm" . "gtk-lock")
+    ("etc/images/next-page.xpm" . "gtk-next-page")
+    ("etc/images/refresh.xpm" . "gtk-refresh")
+    ("etc/images/sort-ascending.xpm" . "gtk-sort-ascending")
+    ("etc/images/sort-column-ascending.xpm" . "gtk-sort-column-ascending")
+    ("etc/images/sort-criteria.xpm" . "gtk-sort-criteria")
+    ("etc/images/sort-descending.xpm" . "gtk-sort-descending")
+    ("etc/images/sort-row-ascending.xpm" . "gtk-sort-row-ascending")
+    ("etc/images/gnus/toggle-subscription.xpm" . "gtk-task-recurring")
+    ("etc/images/mail/compose.xpm" . "gtk-mail-compose")
+    ("etc/images/mail/copy.xpm" . "gtk-mail-copy")
+    ("etc/images/mail/forward.xpm" . "gtk-mail-forward")
+    ("etc/images/mail/inbox.xpm" . "gtk-inbox")
+    ("etc/images/mail/move.xpm" . "gtk-mail-move")
+    ("etc/images/mail/not-spam.xpm" . "gtk-not-spam")
+    ("etc/images/mail/outbox.xpm" . "gtk-outbox")
+    ("etc/images/mail/reply-all.xpm" . "gtk-mail-reply-to-all")
+    ("etc/images/mail/reply.xpm" . "gtk-mail-reply")
+    ("etc/images/mail/save-draft.xpm" . "gtk-mail-handling")
+    ("etc/images/mail/send.xpm" . "gtk-mail-send")
+    ("etc/images/mail/spam.xpm" . "gtk-spam")
+    ;; No themed versions available:
+    ;; mail/preview.xpm (combining stock_mail and stock_zoom)
+    ;; mail/save.xpm    (combining stock_mail, stock_save and stock_convert)
+    ;;
+    )
   "How icons for tool bars are mapped to Gtk+ stock items.
 Emacs must be compiled with the Gtk+ toolkit for this to have any effect.
 A value that begins with n: denotes a named icon instead of a stock icon."
--8<---------------cut here---------------end--------------->8---

[4] Screen shots of Gnus on openSUSE 10.2 using fluxbox: 
<http://theotp1.physik.uni-ulm.de/~ste/comp/emacs/gnus/tool-bar/gtk-stock-map/>

$ rpm -qa|grep -Ee '-icon|-theme'|sort
gnome-icon-theme-2.16.0.1-12
gnome-themes-2.16.1.1-21
gtk2-themes-0.1-671
tango-icon-theme-0.7.2-36
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/