[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Diff faces
From: |
Michael Kifer |
Subject: |
Re: Diff faces |
Date: |
Fri, 12 Oct 2007 15:42:11 -0400 |
> Ediff puts face names as strings on overlays, but describe-face accepts
> only symbols. The patch below fixes describe-face to not fail on face
> name strings. As for fixing ediff, I don't know whether this is
> necessary,
> since face names as strings are mostly interchangeable with face symbols.
> There are only two places in ediff*.el files that call `face-name' to
> convert face symbols to strings, so these calls could be removed.
>
> I agree describe-face should handle a string as the face property,
> since that's a documented feature. So please install that patch.
>
> However, is there a good reason for ediff to use strings
> instead of symbols to specify the faces?
I think that in the old days this is what was required.
Or, maybe for compatibility with XEmacs -- do not remember (was 10 years
back or so).
- Re: Diff faces, (continued)
- Re: Diff faces, Miles Bader, 2007/10/16
- Re: Diff faces, Stefan Monnier, 2007/10/19
- Re: Diff faces, Juri Linkov, 2007/10/19
- Re: Diff faces, Andreas Schwab, 2007/10/19
- Re: Diff faces, Juri Linkov, 2007/10/19
- Re: Diff faces, Stefan Monnier, 2007/10/20
- Re: Diff faces, Stefan Monnier, 2007/10/19
Re: Diff faces, Richard Stallman, 2007/10/12
- Re: Diff faces,
Michael Kifer <=