emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: log-view.el calls non-existent function vc-version-diff


From: Stefan Monnier
Subject: Re: log-view.el calls non-existent function vc-version-diff
Date: Sat, 13 Oct 2007 22:07:58 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux)

>> The only 2 references to vc-version-diff in the whole lisp/ tree are:
>> 
>> ./log-view.el:(autoload 'vc-version-diff "vc")
>> ./log-view.el:    (vc-version-diff (log-view-current-file) to fr)))

> It seems that it should be changed to call vc-history-diff. 

> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...

> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?

In any case, vc.el should provide a backward compatibility definition of
vc-version-diff (and mark it obsolete).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]