Re: XEmacs-sensitive code in tooltip.el?

[Dan Nicolaescu]

David Kastrup <address@hidden> writes:

  > I have seen the following patch recently:
  > 
  > diff --git a/lisp/tooltip.el b/lisp/tooltip.el
  > index a5d0309..ffbebf0 100644
  > --- a/lisp/tooltip.el
  > +++ b/lisp/tooltip.el
  > @@ -273,7 +273,7 @@ is based on the current syntax table."
  >  
  >  (defmacro tooltip-region-active-p ()
  >    "Value is non-nil if the region is currently active."
  > -  (if (string-match "^GNU" (emacs-version))
  > +  (if (not (featurep 'xemacs))
  >        `(and transient-mark-mode mark-active)
  >      `(region-active-p)))
  >  
  > Is this not utterly pointless?  As far as I can see, the whole of
  > tooltip.el is very much Emacs-specific and doesn't have any chance
  > whatsoever for running on XEmacs.  Or am I mistaken about that?

No idea. I just replaced an inefficient test with an equivalent, more
efficient one...