emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: doc-view compilation warnings


From: Tassilo Horn
Subject: Re: doc-view compilation warnings
Date: Tue, 23 Oct 2007 20:41:54 +0200
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux)

Dan Nicolaescu <address@hidden> writes:

>   > +(push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist)
>   > +(push '("\\.[Dd][Vv][Ii]\\'"  . doc-view-mode-maybe) auto-mode-alist)
>   > +(push '("\\.[Pp][Dd][Ff]\\'"  . doc-view-mode-maybe) auto-mode-alist)
>
> In general loading a file should not have side effects like this. 
> IMHO, it is not idea to do things this way...

So what would you suggest?  A function `doc-view-initialize' that does
this?

Oh, and the code has another problem: `push' is a cl function which may
not be used at runtime...

Bye,
Tassilo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]