[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: finish version test cleanup: Lucid
From: |
Glenn Morris |
Subject: |
Re: finish version test cleanup: Lucid |
Date: |
Sun, 28 Oct 2007 20:10:38 -0400 |
User-agent: |
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) |
Vinicius Jose Latorre wrote:
> Dan Nicolaescu wrote:
>> Most string version tests have been replaced with feature tests.
>> These are the remaining ones:
>>
>> ./progmodes/cperl-mode.el:81: (defconst cperl-xemacs-p (string-match
>> "XEmacs\\|Lucid" emacs-version))
>> ./progmodes/cperl-mode.el:154:(defconst cperl-xemacs-p (string-match
>> "XEmacs\\|Lucid" emacs-version))
Could be deleted, since there is a separate stand-alone cperl-mode
that people on other platforms can use. (At the cost of more difference
between the Emacs and standalone version.)
>> ./ielm.el:172: (if (string-match "Lucid" emacs-version)
Could just delete Lucid code.
>> ./ps-print.el:1467: ((string-match "Lucid" emacs-version)
>> ./ps-print.el:1469: ((string-match "Epoch" emacs-version)
Could just be deleted. All they do is refuse to support said
platforms. The rest of Emacs doesn't bother with such checks.
(I imagine ps-print is distributed with all current emacs varieties, so
the number of people downloading standalone versions will be very
small. So you could probably delete _all_ the version-checking code at
the start.)
>> ./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match
>> "Lucid" emacs-version))))
Don't know.
>> ./emulation/tpu-mapper.el:83:(defconst tpu-lucid-emacs19-p (string-match
>> "Lucid" emacs-version)
Could just delete all lucid Emacs 19 support from this file.
- finish version test cleanup: Lucid, Dan Nicolaescu, 2007/10/28
- Re: finish version test cleanup: Lucid, Vinicius Jose Latorre, 2007/10/28
- Re: finish version test cleanup: Lucid,
Glenn Morris <=
- Re: finish version test cleanup: Lucid, Jay Belanger, 2007/10/28
- Re: finish version test cleanup: Lucid, Dan Nicolaescu, 2007/10/28
- Re: finish version test cleanup: Lucid, Jay Belanger, 2007/10/29
- Re: finish version test cleanup: Lucid, David Kastrup, 2007/10/29
- Re: finish version test cleanup: Lucid, Jay Belanger, 2007/10/29
Re: finish version test cleanup: Lucid, Richard Stallman, 2007/10/29