Re: recent changes to display code

[Chong Yidong]

Richard Stallman <address@hidden> writes:

> I'm surprised that this change affected any behavior.  It was only
> supposed to make the argument OVERLAY available to
> face_for_overlay_string.  I will take another look to see what might
> have caused such a problem.
>
> I wonder if there is some hidden constraint on the order of fields in
> `struct it'.

No, the bug arises because of a rather strange (presumable) typo in
your definition of from_overlay in handle_face_prop:

      Lisp_Object from_overlay
      = (it->current.overlay_string_index >= 0
         ? it->string_overlays[it->current.overlay_string_index]
            : from_overlay);
             ^^^^^^^^^^^^

I've fixed this in EMACS_22_BASE.