[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: doc-view warnings
From: |
Tassilo Horn |
Subject: |
Re: doc-view warnings |
Date: |
Fri, 16 Nov 2007 18:04:21 +0100 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) |
Dan Nicolaescu <address@hidden> writes:
Hi Dan!
> These might be bugs:
>
> In doc-view-search-backward:
> doc-view.el:790:20:Warning: reference to free variable `arg'
>
> In doc-view-search:
> doc-view.el:798:17:Warning: reference to free variable `arg'
Oh, yes, they are. Here's the fix:
--8<---------------cut here---------------start------------->8---
2007-11-16 Tassilo Horn <address@hidden>
* doc-view.el (doc-view-search-backward, doc-view-search): Fix
assignment to free variable bug.
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.22
diff -u -r1.22 doc-view.el
--- lisp/doc-view.el 16 Nov 2007 16:50:35 -0000 1.22
+++ lisp/doc-view.el 16 Nov 2007 17:04:02 -0000
@@ -787,7 +787,7 @@
"Call `doc-view-search' for backward search.
If prefix NEW-QUERY is given, ask for a new regexp."
(interactive "P")
- (doc-view-search arg t))
+ (doc-view-search new-query t))
(defun doc-view-search (new-query &optional backward)
"Jump to the next match or initiate a new search if NEW-QUERY is given.
@@ -795,7 +795,7 @@
till now do that first.
If BACKWARD is non-nil, jump to the previous match."
(interactive "P")
- (if (and (not arg)
+ (if (and (not new-query)
doc-view-current-search-matches)
(if backward
(doc-view-search-previous-match 1)
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo