emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: write-file to arbitrary target directory


From: Richard Stallman
Subject: Re: patch: write-file to arbitrary target directory
Date: Sat, 17 Nov 2007 12:42:38 -0500

The change looks useful, but there may be a problem.

    !      (let ((dir  (file-name-directory (buffer-name)))
    !            (file (file-name-nondirectory (buffer-name))))

DIR will nearly always be nil, because buffer names normally
do not include directory parts.

Thus, not using default-directory here

    !        (read-file-name "Write file: "
    !                        dir (expand-file-name file dir) nil file)))

seems like a bug.  What is the aim of that particular change?


Aside from that, it needs changes in the manual (maybe in more than
one place).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]