Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Luca Capello]

Hi all!

On Wed, 21 Nov 2007 01:11:50 +0100, Katsumi Yamaoka wrote:
>>>>>> Andreas Schwab wrote:
>> (defun message-send-mail-function ()
>>   "Return suitable value for the variable `message-send-mail-function'."
>>   (cond ((and sendmail-program
>>         (executable-find program))
>>                          ^^^^^^^
>> Should be sendmail-program?
>
> This doesn't fix it.  While `make bootstrap' I got:
>
> Compiling /Work/emacs/lisp/./mh-e/mh-show.el
> In toplevel form:
> mh-e/mh-show.el:43:1:Error: Symbol's value as variable is void: 
> sendmail-program
>
> Maybe it should be:
>
> (defun message-send-mail-function ()
>   "Return suitable value for the variable `message-send-mail-function'."
>   (cond ((and (boundp 'sendmail-program) sendmail-program)
>             (executable-find sendmail-program))

For me the *obvious* fix is the following:

--8<---------------cut here---------------start------------->8---
Index: lisp/gnus/message.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/message.el,v
retrieving revision 1.127
diff -u -r1.127 message.el
--- lisp/gnus/message.el        9 Nov 2007 09:46:00 -0000       1.127
+++ lisp/gnus/message.el        21 Nov 2007 00:29:49 -0000
@@ -50,7 +50,7 @@
 (require 'mml)
 (require 'rfc822)
 (require 'ecomplete)
-
+(require 'sendmail)
 
 (defgroup message '((user-mail-address custom-variable)
                    (user-full-name custom-variable))
--8<---------------cut here---------------end--------------->8---

Loading the local and modified lisp/gnus/message.el instead of
(require 'message) on an `emacs -Q` clearly sets
`message-send-mail-function' to the documentation default value
`message-send-mail-with-sendmail'.

Thx, bye,
Gismo / Luca