[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] vc-git-dired-state-info buglet
From: |
Dan Nicolaescu |
Subject: |
Re: [patch] vc-git-dired-state-info buglet |
Date: |
Wed, 28 Nov 2007 23:22:03 -0800 |
Alexandre Julliard <address@hidden> writes:
> Thien-Thi Nguyen <address@hidden> writes:
>
> > i think `vc-git-dired-state-info' should call `vc-git-state'
> > instead of `vc-state'. here is a recipe: create dir `test',
> > put it under git version control system, add and commit some
> > files, then modify a subset of the files. then do:
> >
> > C-x v d test RET ; => empty because no files "locked"
> > v t ; => toggle terse mode
> >
> > before the patch, no files are shown w/ "(modified)" status.
> > after the patch, some are shown, as i expected.
> >
> > i wonder if my expectation is incorrect. comments?
>
> That's not the real problem, the other backends also use vc-state here
> and it works fine. The real problem is that vc-git-dir-state is
> broken. Something like this should help:
Thanks, I've checked in this patch.