[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fwd: Patch for sgml-mode.el
From: |
Stefan Monnier |
Subject: |
Re: Fwd: Patch for sgml-mode.el |
Date: |
Thu, 29 Nov 2007 23:46:57 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) |
>>>>> "GM" == Glenn Morris <address@hidden> writes:
> Stefan Monnier wrote:
>>> Furthermore, it results in "mode-name" not being a string
>>> for html buffers.
>>
>> I don't see a problem with that. It's obviously been done on purpose.
>> Please describe where it causes a problem so we can fix that spot.
> I have being meaning to post about this.
> See for example
> http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg00891.html
> From: h1t
> Subject: Bug in ibuffer-mark-by-mode-regexp function
> Date: Wed, 14 Nov 2007 10:27:04 +0200
> A quick grep for mode-name in lisp/ appears to show several places
> that assume it is a string. It's documented as being a string, so I
> would think at the very least should be a NEWS entry saying it might
> not be any more.
Does the patch below fix those problems?
Stefan
Index: lisp/ibuffer.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/ibuffer.el,v
retrieving revision 1.88
diff -u -r1.88 ibuffer.el
--- lisp/ibuffer.el 19 Nov 2007 08:50:03 -0000 1.88
+++ lisp/ibuffer.el 30 Nov 2007 04:46:25 -0000
@@ -1722,7 +1722,7 @@
('mouse-face 'highlight
'keymap ibuffer-mode-name-map
'help-echo "mouse-2: filter by this mode"))
- (format "%s" mode-name))
+ (format-mode-line mode-name))
(define-ibuffer-column process
(:summarizer
Index: lisp/ibuf-ext.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/ibuf-ext.el,v
retrieving revision 1.59
diff -u -r1.59 ibuf-ext.el
--- lisp/ibuf-ext.el 23 Oct 2007 15:54:06 -0000 1.59
+++ lisp/ibuf-ext.el 30 Nov 2007 04:46:25 -0000
@@ -1134,11 +1134,11 @@
(string-lessp (downcase
(with-current-buffer
(car a)
- mode-name))
+ (format-mode-line mode-name)))
(downcase
(with-current-buffer
(car b)
- mode-name))))
+ (format-mode-line mode-name)))))
;;;###autoload (autoload 'ibuffer-do-sort-by-alphabetic "ibuf-ext")
(define-ibuffer-sorter alphabetic
@@ -1386,7 +1386,7 @@
(ibuffer-mark-on-buffer
#'(lambda (buf)
(with-current-buffer buf
- (string-match regexp mode-name)))))
+ (string-match regexp (format-mode-line mode-name))))))
;;;###autoload
(defun ibuffer-mark-by-file-name-regexp (regexp)