emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: odd code in dbusbind.c


From: Tom Tromey
Subject: Re: odd code in dbusbind.c
Date: Sun, 30 Dec 2007 14:05:35 -0700
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux)

>>>>> "Michael" == Michael Albinus <address@hidden> writes:

Michael> Thanks a lot for your review. All mentioned points shall be
Michael> fixed now.

Thanks!

Here's one more I ran into -- I was copying parts of dbusbind.c for my
status icon patch, and this looked odd.  Other places in Emacs seem to
use non-static input_event structs this way.  kbd_buffer_store_event
could be clearer about whether the event is copied or the pointer is
stored, though...

Tom

Index: dbusbind.c
===================================================================
RCS file: /sources/emacs/emacs/src/dbusbind.c,v
retrieving revision 1.14
diff -u -c -r1.14 dbusbind.c
cvs diff: conflicting specifications of output style
*** dbusbind.c  30 Dec 2007 15:55:29 -0000      1.14
--- dbusbind.c  30 Dec 2007 21:32:56 -0000
***************
*** 962,968 ****
  {
    Lisp_Object args, key, value;
    struct gcpro gcpro1;
!   static struct input_event event;
    DBusConnection *connection;
    DBusMessage *dmessage;
    DBusMessageIter iter;
--- 962,968 ----
  {
    Lisp_Object args, key, value;
    struct gcpro gcpro1;
!   struct input_event event;
    DBusConnection *connection;
    DBusMessage *dmessage;
    DBusMessageIter iter;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]