emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: toggling diff-auto-refine


From: Stefan Monnier
Subject: Re: toggling diff-auto-refine
Date: Tue, 01 Jan 2008 21:37:22 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

> how about replacing the `(defcustom diff-auto-refine ...)' with:
> (define-minor-mode diff-auto-refine
>   "Automatically highlight changes in detail as the user visits hunks."
>   :group 'diff-mode :init-value nil :lighter " Auto-Refine"
>   (when diff-auto-refine
>     (condition-case-no-debug nil (diff-refine-hunk) (error nil))))

Fine by me, but:
- please call it "-mode" then.
- not sure if the merged mode for smerge+diff should use the
  "diff" prefix.  After all, the actual main code is in the
  smerge-mode.el file, so maybe the "smerge-" prefix would be
  more consistent.  Then again, moving this code out of smerge to some
  shared place might be even better.


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]