Re: 23.0.50; dbus

[Stefan Monnier]

> Here I'm lost. I use something like

>   if (NILP (uname) || (strlen (SDATA (uname)) > 0))

> uname is a Lisp_Object. SDATA (uname) returns (char *). What kind of
> signedness do I break in strlen? Does anybody have an idea?

Someone else already answered the question, but I'll just take the
opportunity to point out that the above code is a common small bug:
the strlen may crash if uname is neither nil nor a string.
A better way to write such code is

   if (STRINGP (uname) && (strlen (SDATA (uname)) > 0))

Another benefit is that the compiler can do a better job of
eliminating the (now) redundant STRINGP test that may lurk
inside SDATA.


        Stefan