emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: browse-url-firefox


From: Lennart Borgman (gmail)
Subject: Re: browse-url-firefox
Date: Sat, 05 Jan 2008 19:16:07 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666

Eli Zaretskii wrote:
Date: Sat, 05 Jan 2008 18:31:22 +0200
From: Eli Zaretskii <address@hidden>
Cc: address@hidden

          (apply 'start-process
                 (concat "firefox " url) nil
                 browse-url-firefox-program
                 (append
                  browse-url-firefox-arguments
                  (if (or (featurep 'dos-w32)
                          (string-match "win32" system-configuration))
                      (list url)
                    (list "-remote"
                          (concat "openURL("
                                  url
                                  (if (browse-url-maybe-new-window
                                       new-window)
                                      (if browse-url-firefox-new-window-is-tab
                                          ",new-tab"
                                        ",new-window"))
                                  ")")))))))

has the effect of invoking Firefox with the URL specified twice on the
command line (so Firefox opens it in two tabs).  I think it's a bug,
and that the right fix is to not (concat "firefox " url), but to use a
literal "firefox" instead.  Does anyone see where I'm wrong?

The second argument to `start-process' is just a name so I can see nothing wrong with that it is (concat "firefox " url).

BTW, why are the arguments different on w32? It looks like the other path works for w32 too.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]