Re: address@hidden: some code issues]

[Chong Yidong]

> I had a quick look at the pop.c code today and found some
> issues.
>
> In pop_stat:
>
> If I don't miss anything the atoi call in 380 is not save as it is not
> save because it is not ensure that &fromserver[4] is not NULL. A crafted
> pop3 server could thus crash emacs. This is of course not a real issue but
> wouldn't be nice. Same for the pop_last function.
>
> In pop_list:
>
> in 441 and 442 there should be some check for how_many to prevent an integer
> overflow here.

Fixed.  Thanks for pointing these out.

> Same problem for the xnew macro in etags.c

I don't think this is a problem, considering the way the xnew macro is
called in etags.c --- unless you can point to a specific problem.