RE: wrong-type-argument in gud-tooltip-mode

[Nick Roberts]

 > > Also I've tried to reproduce the error in emacs-unicode-2 and on the trunk
 > > but can't.
 > 
 > It is easy to reproduce now, even without gdb.  Since the buffer 
 > " *partial-output-*" does not visit any file, the FILE argument provided
 > to `file-exists-p' will be nil.  However,
 > 
 >   (file-exists-p nil)
 >   error--> Wrong type argument: stringp, nil
 > 
 > That is the error.
 
Yes, that is easy!  I can see it in the *Messages* buffer now.  I was fooled
because I thought I'd see any error in the mini-buffer.  I'm a bit confused
about when errors do get printed there now.

How about the patch below.  There seems to be no point in running call-process
with no input file.  I could probably also remove the string-match for
"\\`\\*.+\\*\\'" in gud-tooltip-mode too, as these buffers have no files
associated with them anyway.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** gdb-ui.el.~1.218.~  2008-01-23 17:34:20.000000000 +1300
--- gdb-ui.el   2008-01-27 23:06:38.000000000 +1300
*************** otherwise do not."
*** 435,445 ****
         (output
          (with-output-to-string
            (with-current-buffer standard-output
!             (call-process shell-file-name
!                           (if (file-exists-p file) file nil)
                            (list t nil) nil "-c"
                            (concat gdb-cpp-define-alist-program " "
!                                   gdb-cpp-define-alist-flags)))))
        (define-list (split-string output "\n" t)) (name))
      (setq gdb-define-alist nil)
      (dolist (define define-list)
--- 435,445 ----
         (output
          (with-output-to-string
            (with-current-buffer standard-output
!             (and file (file-exists-p file)
!             (call-process shell-file-name file
                            (list t nil) nil "-c"
                            (concat gdb-cpp-define-alist-program " "
!                                   gdb-cpp-define-alist-flags))))))
        (define-list (split-string output "\n" t)) (name))
      (setq gdb-define-alist nil)
      (dolist (define define-list)