emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: buffer is modified after commit


From: Stefan Monnier
Subject: Re: buffer is modified after commit
Date: Wed, 13 Feb 2008 17:01:37 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

>> 3 - buffer-modified-p is incorrectly forcefully set to nil by the
>> special undo entries added in highlight-changes-rotate-faces.
>> That's correct if the buffer was not modified before undoing
>> this command, but is dangerous otherwise (will mark your buffer as
>> unmodified even though you haven't saved the changes).

> Yes, that part is tricky and should be solved by a generic primitive
> rather than my ad-hoc fix.  I thought that when the buffer is unmodified
> at the time I do "this command", doing/undoing "this command" and
> setting the modified status to nil should not cause any harm.  Can you
> provide a counterexample?

edit
save
rotate
edit
save
undo undo undo...

By the way, I've installed a change on the 22 branch which should fix
the buffer-modified-p problem (and removes this number 3 hack).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]