Re: vc-set-mode-line-busy-indicator

[Nick Roberts]

Nick Roberts writes:
 > 
 > The problem with this message is that it is so long that the bit after
 > ("from filename") doesn't fit in 80 columns.  Also a warning-face isn't
 > really needed because it doesn't provide a wake up call: the user has just
 > entered a command, e.g, vc-diff or vc-print-log, so presumably he's already
 > looking for the output buffer.
 > 
 > I've used the same style as I've used for the GUD buffer.  If text in the
 > mode-line is going to be increasingly fontified, it might be a good idea to
 > have some consistency.

I forgot to ask:

Shall I apply this patch?

 > -- 
 > Nick                                           
 > http://www.inet.net.nz/~nickrob
 > 
 > 
 > *** vc.el.~1.541.~   2008-02-24 08:24:18.000000000 +1300
 > --- vc.el    2008-02-26 01:29:24.000000000 +1300
 > *************** BUF defaults to \"*vc*\", can be a strin
 > *** 1064,1077 ****
 >   
 >   (defun vc-set-mode-line-busy-indicator ()
 >     (setq mode-line-process
 > !    ;; Deliberate overstatement, but power law respected.
 > !    ;; (The message is ephemeral, so we make it loud.)  --ttn
 > !    (propertize " (incomplete/in progress)"
 > !                'face (if (featurep 'compile)
 > !                          ;; ttn's preferred loudness
 > !                          'compilation-warning
 > !                        ;; suitably available fallback
 > !                        font-lock-warning-face)
 >                  'help-echo
 >                  "A VC command is in progress in this buffer")))
 >   
 > --- 1064,1071 ----
 >   
 >   (defun vc-set-mode-line-busy-indicator ()
 >     (setq mode-line-process
 > !    (propertize " [waiting...]"
 > !                'face 'font-lock-variable-name-face
 >                  'help-echo
 >                  "A VC command is in progress in this buffer")))
 >