Re: vc-set-mode-line-busy-indicator

[Glenn Morris]

Nick Roberts wrote:

>  > Sorry, but now this is installed I see it is totally invisible on my
>  > mode-line.
>  > 
>  > Please can I either remove the 'face altogether or create a new face
>  > for it. I don't care which.
>
> I committed it because that seemed to fit the culture being advocated.  If it
> doesn't work for you then please do change it accordingly.

I don't know nothing' 'bout no culture...

I should have tried it out to see how it looked.

If people feel the need to emphasize certain mode-line features (and
if you did a similar thing for gud, there probably is such a need),
then I would say it needs a new face; because the mode-line palette is
different to the buffer palette.

I suggest a new `mode-line-emphasis' face. The existing
`mode-line-highlight' doesn't look right because it is designed for
buttons. I made up some defaults; I'm not sure about them.


*** faces.el.~1.394.~   2008-02-23 11:24:00.000000000 -0800
--- faces.el    2008-03-01 14:47:47.000000000 -0800
***************
*** 2388,2398 ****
       :box (:line-width 2 :color "grey40" :style released-button))
      (t
       :inherit highlight))
!   "Basic mode line face for highlighting."
    :version "22.1"
    :group 'mode-line-faces
    :group 'basic-faces)
  
  (defface mode-line-buffer-id
    '((t (:weight bold)))
    "Face used for buffer identification parts of the mode line."
--- 2388,2409 ----
       :box (:line-width 2 :color "grey40" :style released-button))
      (t
       :inherit highlight))
!   "Basic mode line face for highlighting (of buttons, etc)."
    :version "22.1"
    :group 'mode-line-faces
    :group 'basic-faces)
  
+ (defface mode-line-emphasis
+   '((((class color) (min-colors 88))
+      :background "grey40")
+     (t
+      :inherit highlight))
+   "Face used to emphasize certain mode line features.
+ Use the face `mode-line-highlight' for features that can be selected."
+   :version "23.1"
+   :group 'mode-line-faces
+   :group 'basic-faces)
+ 
  (defface mode-line-buffer-id
    '((t (:weight bold)))
    "Face used for buffer identification parts of the mode line."


*** vc.el.~1.545.~      2008-03-01 11:41:50.000000000 -0800
--- vc.el       2008-03-01 14:43:10.000000000 -0800
***************
*** 1063,1072 ****
  
  (defun vc-set-mode-line-busy-indicator ()
    (setq mode-line-process
!       (propertize " [waiting...]"
!                   'face 'font-lock-variable-name-face
                    'help-echo
!                   "A VC command is in progress in this buffer")))
  
  (defun vc-exec-after (code)
    "Eval CODE when the current buffer's process is done.
--- 1063,1072 ----
  
  (defun vc-set-mode-line-busy-indicator ()
    (setq mode-line-process
!       (concat " " (propertize "[waiting...]"
!                                 'face 'mode-line-emphasis
                                  'help-echo
!                                 "A VC command is in progress in this 
buffer"))))
  
  (defun vc-exec-after (code)
    "Eval CODE when the current buffer's process is done.