Re: make-glyph-code incompatibility

[Kim F. Storm]

Stefan Monnier <address@hidden> writes:

>>> The new make-glyph-code is a good change, but it introduces
>>> an incompatibility.  It seems that it makes previously working code
>>> fail silently.  Can we make it fail with an informative message?
>
>> The new encoding still merges a face id and char code into
>> an integer if the face id is < 64.  So an integer value may
>> still carry a face id in the upper bits.
>
> Is it worth the trouble?

Maybe not, but it's already done...
And the code overhead is neglible.

> I was thinking maybe we could display such invalid glyphs as a string
> "invalid-glyph".

Wouldn't fit nicely in the vertical bar or as "truncation marker"...

> But I definitely do not want to expand a lot of effort into
> this checking.  I just figured that maybe there's a cheap way to detect
> the problem and make the failure easier to diagnose (compared to "my
> vertical tab line doesn't show any more" which is harder to debug
> unless we know that the vertical tab line is using glyphs).

I think a notice in NEWS is sufficient...

-- 
Kim F. Storm <address@hidden> http://www.cua.dk