Re: isearch-push-state

[Stefan Monnier]

Thanks Juri.  I'm not sure I understand what you said: are you saying
that those extra state-pushes are just unnecessary or are they
really harmful?  It seems they are harmful w.r.t the new
failed-search-highlight thingy, but shouldn't the failed-search-highlight
thingy try to pop several states until findind one that
does succeed?

I'm not sure I like the idea that "spurious" state pushes can really
be harmful.

This said, wherever you remove those pushes, please replace them with
a comment mentioning that it was there and why you think
it's unnecessary.


        Stefan



> Index: lisp/isearch.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/isearch.el,v
> retrieving revision 1.313
> diff -c -r1.313 isearch.el
> *** lisp/isearch.el   28 Feb 2008 01:57:42 -0000      1.313
> --- lisp/isearch.el   10 Mar 2008 17:56:09 -0000
> ***************
> *** 1096,1104 ****
>           ;; Only the string actually used should be saved.
>           ))
  
> -     ;; Push the state as of before this C-s.
> -     (isearch-push-state)
> - 
>       ;; Reinvoke the pending search.
>       (isearch-search)
>       (isearch-push-state)
> --- 1081,1086 ----
> ***************
> *** 1895,1904 ****
>     (if search-ring-update
>         (progn
>       (isearch-search)
>       (isearch-update))
> !     (isearch-edit-string)
> !     )
> !   (isearch-push-state))
  
>   (defun isearch-ring-advance ()
>     "Advance to the next search string in the ring."
> --- 1887,1895 ----
>     (if search-ring-update
>         (progn
>       (isearch-search)
> +     (isearch-push-state)
>       (isearch-update))
> !     (isearch-edit-string)))
  
>   (defun isearch-ring-advance ()
>     "Advance to the next search string in the ring."

> -- 
> Juri Linkov
> http://www.jurta.org/emacs/