emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: d


From: Juri Linkov
Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning
Date: Thu, 13 Mar 2008 12:37:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-unknown-linux-gnu)

>> When testing Emacs 22 with `emacs -Q', I see that dired buffers are
>> almost unusable by default.  The red bold face for write permissions
>> is very distracting that prevents focusing on other parts of the dired
>> buffer.  I'm afraid Emacs users will hate us for this if we release
>> Emacs 22.2 with this annoyance.
>>
>> I propose a patch below for the 22 branch that renames the face
>> `dired-warn-writable' to more appropriate name `dired-perm-write'
>> that doesn't associate it with a warning, and changes its parent face
>> from `font-lock-warning-face' to `font-lock-comment-delimiter-face'
>> on non-Windows platforms.
>
> I object.  I think now is not the time for making behavioral changes
> in the release branch.  We are too close to the release.

This is not a behavioral change.  This is a fix for the grave usability bug
you introduced to GNU/Linux users.  It seems you realize the severity of
this problem since you wrote several times proposing to fix it:

> Date: Sun, 14 Oct 2007 06:10:33 +0200
> From: Eli Zaretskii <address@hidden>
> Then perhaps the new face dired-warn-writable that I introduced
> yesterday should inherit from `default' on _all_ platforms, not only
> on DOS/Windows.

and

> Date: Mon, 15 Oct 2007 00:20:45 +0200
> From: Eli Zaretskii <address@hidden>
> It does fix that on platforms where group- and world-writable files
> are the default.  On other platforms, you can customize it, or we can
> make it inherit from `default' on _all_ platforms.

I think it is not yet too late to fix this bug because there is absolutely
no risk of breaking something else with this simple fix.

-- 
Juri Linkov
http://www.jurta.org/emacs/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]