Re: C-r and C-s in minibuffer should search completion

[Stefan Monnier]

>> There seem to be some typo or something missing from your sentence, but
>> IIUC you have implemented what I suggested so that M-n only computes the
>> completion table after having consumed the normal defaults?  Can you
>> send the new code?

> Yep, this was already implemented in my previous patch.

I must have missed it.

> If there exist a default value, then the first M-n just inserts this
> default value to the minibuffer without any computation, and only next
> M-n (that would otherwise signal an error) computes the
> completion table.

Yes, that's good.

> Below is a new patch with a small improvement: it introduces a new
> variable `minibuffer-default-add-p' useful to add more elements to the
> list of defaults several times in chunks when needed (it can keep the
> current state of added elements to the list of defaults):

OK, then please remove (make-variable-buffer-local
'minibuffer-default-add-function).  And I suggest to change
minibuffer-default-add-p into minibuffer-default-add-done (and to
reverse its default to nil).

Also the docstring of minibuffer-default-add-function needs to mention
that the function should set minibuffer-default-add-done.

This said, I'm wondering when the chunked computation makes sense.
Do you have an example in mind?


        Stefan