Re: 23.0.60; Resizing may delete windows

[Stefan Monnier]

>> I'm not sure I understand what you mean: window-min-(height|width) is
>> a variable.  Where do you get your constants from?

> The only constants in this context are MIN_SAFE_WINDOW_(HEIGHT|WIDTH).
> window-min-(height|width) are variables the user can try to set.  If
> they are less than MIN_SAFE_WINDOW_(HEIGHT|WIDTH) check_min_window_sizes
> will reset them.  And, in window_min_size_2 I check them again to not
> produce a new height or width that would omit the modeline or
> scroll-bars if these shall be shown.

Right, but in your message you referred to 1 and 2, rather than to
window-min-(height|width).  As far as I can tell, we're discussing
window resizing which is only affected by window-min-(height|width).
MIN_SAFE_WINDOW_(HEIGHT|WIDTH) only affect window-min-(height|width), so
it only affects resizing in a very indirect manner (e.g. we can scan
all windows, reset window-min-(height|width) to valid values and the
resize without paying attention to MIN_SAFE_WINDOW_(HEIGHT|WIDTH)).

> /* The smallest acceptable dimensions for a window.  Anything smaller
>    might crash Emacs.  */
> #define MIN_SAFE_WINDOW_WIDTH  (2)
> #define MIN_SAFE_WINDOW_HEIGHT (2)

> which, by virtue of brute force, would eliminate our problems as well.

Yes, but I do use 1-line-high windows, and disallowing them just because
we can't be bothered to write the window-resize code in the right way
isn't the right answer.


        Stefan