[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Window-groups
From: |
joakim |
Subject: |
Re: [PATCH] Window-groups |
Date: |
Mon, 23 Jun 2008 16:29:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
Richard M Stallman <address@hidden> writes:
> Please stick to our coding style. Please follow the conventions of
> spacing and indentation that are used throughout the code.
>
> case DELETE_OTHER_WINDOWS:
> - if (!EQ (window, obj))
> + if (!EQ (window, obj) )
>
> There shouldn't be a space between two closeparens.
>
> + if(!NILP(Fwindow_parameter(window, Qgroup)))
>
> Please put spaces before all those openparens. Likewise in the many
> similar cases. The only time an openparen should have no preceding
> space is when it follows another openparen or an openbracket or a
> unary operator.
>
> + foreach_window_1 (XWINDOW (FRAME_ROOT_WINDOW (f)), fn,
> user_data,allwindows);
>
> Please put a space after every comma.
>
> + else{
>
> Please put the open brace on a separate line.
>
>
> Please do not mess up the code by introducing variation in these style
> questions. Please don't leave it to someone else to fix these things.
These concerns will be addressed in the next version of the patch.
--
Joakim Verona