Re: visual-line-mode

[Chong Yidong]

Stefan Monnier <address@hidden> writes:

>> BTW, while C-n and C-p work great with Stefan's patch (with both fixed-
>> and variable-pitch fonts), C-a and C-e act oddly (though they actually
>> do act somewhat differently when line-move-visual is t).
>
> Indeed, my patch does not update C-a and C-e.  Not sure what you mean
> by "oddly", tho.  I've been using my patch ever since I posted it and
> haven't noticed anything strange with it.
>
> PS: My patch is just a proof of concept.  It has a few bugs.  One of
> them can be seen when you set truncate-lines, in which case it doesn't
> preserve columns correctly (basically, its temporary-goal-column ends
> up being computed from the beginning of the displayed part of the
> line, so as long as hscroll is not changed, it works OK but as soon as
> hscroll is modified, the result is incorrect).

I think that in order to be useful, this feature ought to be provided as
a minor mode that rebinds keys, not a direct modification of the motion
code like in your patch.  Then we can also handle C-k etc. properly.

Also, David Reitter's minor mode handles variable-width fonts.  AFAICT,
your patch doesn't support that, or at least not without a further
extension of vertical-motion to support a pixel goal.

So I think we ought to check in David's code.  Once that's done, we can
see about extending vertical-motion and making the minor mode use that,
for increased speed.

WDYT?