Re: Cocoa Emacs crashes when background color is set

[Chong Yidong]

David Whetstone <address@hidden> writes:

>> I checked out Emacs from CVS yesterday, built and installed on Mac
>> OS X
>> Leopard --with-ns
>>
>> With emacs -q, this call
>>
>> (set-background-color "black")
>>
>> exits the whole application.  I can provide detailed tracing next
>> week if it can't be replicated by Adrian or anyone else; I won't have
>> access to Leopard until then (and yesterday I only had a few minutes,
>> sorry this is a very barebones bug report).
>
> Just so we don't duplicate effort, I've already traced the source of
> the problem which I reported this last month before the merge on both
> the address@hidden mailing list:

Maybe the following patch fixes this (1000% untested).

*** trunk/src/nsfns.m.~1.6.~    2008-07-17 10:49:13.000000000 -0400
--- trunk/src/nsfns.m   2008-07-18 14:13:27.000000000 -0400
***************
*** 400,406 ****
        face = FRAME_DEFAULT_FACE (f);
        if (face)
          {
!           col = NS_FACE_BACKGROUND (face);
            face->background
             = (EMACS_UINT) [[col colorWithAlphaComponent: alpha] retain];
            [col release];
--- 400,406 ----
        face = FRAME_DEFAULT_FACE (f);
        if (face)
          {
!           col = ns_lookup_indexed_color (NS_FACE_BACKGROUND (face), f);
            face->background
             = (EMACS_UINT) [[col colorWithAlphaComponent: alpha] retain];
            [col release];