[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs.c broken by revision 1.435
|
From: |
Stefan Monnier |
|
Subject: |
Re: emacs.c broken by revision 1.435 |
|
Date: |
Wed, 23 Jul 2008 15:57:10 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
> The "LINUX_SBRK_BUG" condition was incorrectly replaced with
> #if (GNU_LINUX) && __GNU_LIBRARY__ - 0 < 6
> __sbrk (1);
> #endif
Indeed Dan, this looks wrong. Beside the obvious lack of "defined",
this change activates this code for all platforms rather than just
Alpha, and it makes the code less readable: the previous use of the
"LINUX_SBRK_BUG" identifier made it clear what the purpose was, and
clearly separated the bug&bugfix part from the detection of the bug.
I.e. the previous code was better.
Stefan