Re: Failure bootstrapping Emacs (Cygwin)

[Dan Nicolaescu]

Angelo Graziosi <address@hidden> writes:

  > Angelo Graziosi ha scritto:
  > > Current trunk fails in this waY:
  > >
  > > [...]
  > > term.o: In function `dissociate_if_controlling_tty':
  > > /work/emacs/src/term.c:3216: undefined reference to `_EMACS_GET_TTY_PGRP'
  > > emacs.o: In function `shut_down_emacs':
  > > /work/emacs/src/emacs.c:2031: undefined reference to `_EMACS_GET_TTY_PGRP'
  > > callproc.o: In function `child_setup':
  > > /work/emacs/src/callproc.c:1257: undefined reference to
  > > _EMACS_SET_TTY_PGRP'
  > > collect2: ld returned 1 exit status
  > > make[1]: *** [temacs.exe] Error 1
  > > make[1]: Leaving directory `/work/build/src'
  > > make: *** [src] Error 2
  > >
  > > This does not happen with trunk of a few hours before.
  > >
  > 
  > 
  > > Perhaps this changes are the cause:
  > >
  > > 2008-07-31  Dan Nicolaescu  <address@hidden>
  > >
  > >     * bitmaps/README:
  > >     * xfns.c:
  > >     * termcap.c:
  > >     * term.c:         <==
  > >     * syswait.h:
  > >     * systty.h:
  > >     * systime.h:
  > >         [...]
  > >
  > ^^^^^^^ wrong ! ^^^^^^^^^^^^^^
  > 
  > This is the cause:
  > 
  > 2008-07-30  Dan Nicolaescu  <address@hidden>
  > 
  >         * systty.h (sensemode): Remove empty #if.  Remove reference to
  >         BSD_TERMIOS, unused.
  > 
  > Restoring to systty.h:
  > 
  > #if defined (HAVE_TERMIOS) && ! defined (BSD_TERMIOS)       
  >             

This looks plausible, and the change had a logic error:
&& ! defined (BSD_TERMIOS) when BSD_TERMIOS is never defined is
equivalent to
#if defined (HAVE_TERMIOS)

not to #if 0 as the change assumed.

I'll check in a fix later today if nobody beats me to it.