Warning starting Emacs (was Re: Failure bootstrapping Emacs (Cygwin))

[Angelo Graziosi]

Dan Nicolaescu ha scritto:
> Angelo Graziosi <address@hidden> writes:
>
>   > Angelo Graziosi ha scritto:
>   > > Current trunk fails in this waY:
>   > >
>   > > [...]
>   > > term.o: In function `dissociate_if_controlling_tty':
>   > > /work/emacs/src/term.c:3216: undefined reference to `_EMACS_GET_TTY_PGRP'
>   > > emacs.o: In function `shut_down_emacs':
>   > > /work/emacs/src/emacs.c:2031: undefined reference to `_EMACS_GET_TTY_PGRP'
>   > > callproc.o: In function `child_setup':
>   > > /work/emacs/src/callproc.c:1257: undefined reference to
>   > > _EMACS_SET_TTY_PGRP'
>   > > collect2: ld returned 1 exit status
>   > > make[1]: *** [temacs.exe] Error 1
>   > > make[1]: Leaving directory `/work/build/src'
>   > > make: *** [src] Error 2
>   > >
>   > > This does not happen with trunk of a few hours before.
>   > >
>   > 
>   > 
>   > > Perhaps this changes are the cause:
>   > >
>   > > 2008-07-31  Dan Nicolaescu  <address@hidden>
>   > >
>   > >     * bitmaps/README:
>   > >     * xfns.c:
>   > >     * termcap.c:
>   > >     * term.c:         <==
>   > >     * syswait.h:
>   > >     * systty.h:
>   > >     * systime.h:
>   > >         [...]
>   > >
>   > ^^^^^^^ wrong ! ^^^^^^^^^^^^^^
>   > 
>   > This is the cause:
>   > 
>   > 2008-07-30  Dan Nicolaescu  <address@hidden>
>   > 
>   >         * systty.h (sensemode): Remove empty #if.  Remove reference to
>   >         BSD_TERMIOS, unused.
>   > 
>   > Restoring to systty.h:
>   > 
>   > #if defined (HAVE_TERMIOS) && ! defined (BSD_TERMIOS) 	
>   >          
>
> This looks plausible, and the change had a logic error:
> && ! defined (BSD_TERMIOS) when BSD_TERMIOS is never defined is
> equivalent to
> #if defined (HAVE_TERMIOS)
>
> not to #if 0 as the change assumed.
>
> I'll check in a fix later today if nobody beats me to it.

For the sake of completeness, I have applied this:

$ cat downloads/emacs.ports/systty.h.diff
--- systty.h.orig       2008-07-31 16:13:42.000000000 +0200
+++ systty.h    2008-07-31 18:43:08.625000000 +0200
@@ -151,12 +151,20 @@

 #ifdef EMACS_HAVE_TTY_PGRP

+#if defined (HAVE_TERMIOS)
+
+#define EMACS_GET_TTY_PGRP(fd, pgid) (*(pgid) = tcgetpgrp ((fd)))
+#define EMACS_SET_TTY_PGRP(fd, pgid) (tcsetpgrp ((fd), *(pgid)))
+
+#else
+
 #ifdef TIOCSPGRP

 #define EMACS_GET_TTY_PGRP(fd, pgid) (ioctl ((fd), TIOCGPGRP, (pgid)))
 #define EMACS_SET_TTY_PGRP(fd, pgid) (ioctl ((fd), TIOCSPGRP, (pgid)))

 #endif /* TIOCSPGRP */
+#endif /* HAVE_TERMIOS */

 #else /* not EMACS_SET_TTY_PGRP */

with which current trunk bootstraps, but starting Emacs it opens a 
buffer called Warnings in which it prints:

<beep>
Emergency (alloc): Warning: past 95% of memory limit

Perhaps, here, we have some other problems...

   Angelo.