Re: a little feedback on Cocoa Emacs.app

[Adrian Robert]

On Aug 4, 2008, at 8:42 AM, address@hidden wrote:

> > +- (void)newFrame: (id)sender
> > +{
> > +  Feval (Fcons (intern ("make-frame"), Qnil));
> > +}
> > +
>
> Strictly speaking, Feval calls inside read_socket_hook are not
> allowed by design, although the Cocoa/GNUstep port is using it
> extensively...

Yes.. I was going to change this to use an alternative method similar  
to your patch below before committing.  And the other Fevals are still  
slated for removal -- just been a lot of higher-priority items since  
the previous discussion.


>    err = AppendMenuItemTextWithCFString (menu, CFSTR ("New Frame"),
>                                           0, kHICommandNew, NULL);
> ...
>  (put 'new 'mac-apple-event-id "new ") ; kHICommandNew
>  (define-key mac-apple-event-map [hi-command new] 'make-frame)